Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LibGpiodDriver V2 driver public #2386

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
c49a652
Clean up LibGpiodDriver interface
pgrawehr Feb 1, 2025
a36b037
Provide new GpioChipInfo static method
pgrawehr Feb 8, 2025
cca72d9
Undo previous change
pgrawehr Feb 14, 2025
e7630b4
Revert "Clean up LibGpiodDriver interface"
pgrawehr Feb 14, 2025
09bc615
Revert to old behavior: LibgpiodDriver is V1, V2 is separate
pgrawehr Feb 14, 2025
f996165
This was now doubled
pgrawehr Feb 15, 2025
319c83d
Add test for SysFs
pgrawehr Feb 16, 2025
8e9aca1
Implement method
pgrawehr Feb 16, 2025
7673379
Why does this not fit?
pgrawehr Feb 16, 2025
a4d8557
Something is strange here
pgrawehr Feb 16, 2025
69fc9c0
There's a bug here
pgrawehr Feb 16, 2025
13d1305
Better now?
pgrawehr Feb 16, 2025
f515521
Provide implementation for LibgpiodV1
pgrawehr Feb 16, 2025
44ee48d
Need to debug this
pgrawehr Feb 16, 2025
85ba42e
Avoid crash, maybe?
pgrawehr Feb 16, 2025
d3dea5b
Could be working
pgrawehr Feb 16, 2025
5369470
No duplicates here
pgrawehr Feb 16, 2025
5b60bd0
Why is that crashing?
pgrawehr Feb 16, 2025
4b2e660
Disable this test, because it seems it does now crash
pgrawehr Feb 16, 2025
ee2f463
Something crashes very ugly here
pgrawehr Feb 16, 2025
5b4d464
Make sure this test is the culprit
pgrawehr Feb 16, 2025
7a3750b
Revert previous change
pgrawehr Feb 16, 2025
8762dd1
Maybe not closing the stuff avoids the crash
pgrawehr Feb 16, 2025
ef07261
No crashes any more?
pgrawehr Feb 16, 2025
66d8882
Chip info for V2 completed
pgrawehr Feb 27, 2025
4a01067
Add Test for V2
pgrawehr Mar 1, 2025
bdc9cc0
Minor fix
pgrawehr Mar 1, 2025
6121e7a
Fix #2384: Avoid exception when toggling a pin whose current value is…
pgrawehr Mar 1, 2025
0eaf202
Stylecop error fixed
pgrawehr Mar 2, 2025
46fd6cd
Improve parsing
pgrawehr Mar 2, 2025
80e5fdd
This should be the right pattern
pgrawehr Mar 2, 2025
bfbe8eb
Try to make it work on RPI3, too
pgrawehr Mar 2, 2025
ec4a249
Something behaves differently on the RPI3
pgrawehr Mar 2, 2025
e452358
Stupid me
pgrawehr Mar 2, 2025
372e030
Is a directory
pgrawehr Mar 2, 2025
98c31f7
Cleanup
pgrawehr Mar 2, 2025
a8a44da
Use new method to fix a TODO
pgrawehr Mar 10, 2025
a4ee7de
Make it more clear how this handle is used
pgrawehr Mar 15, 2025
0d60d18
Review findings
pgrawehr Mar 15, 2025
0599ce4
Adjust namespaces
pgrawehr Mar 15, 2025
f570cd2
That didn't compile
pgrawehr Mar 16, 2025
81eec32
Mark new stuff experimental for now
pgrawehr Mar 22, 2025
eff2f8e
Include ChipInfo in QueryComponentInformation
pgrawehr Mar 27, 2025
6f128dc
Some more review findings
pgrawehr Mar 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
pgrawehr committed Mar 2, 2025
commit 98c31f73be47525c601e51846eb406bdf4659aae
Original file line number Diff line number Diff line change
@@ -130,7 +130,7 @@ public static IList<GpioChipInfo> GetAvailableChips()
// Add the default entry (the first entry, but we name it "0")
// There's no such actual entry on RPI4, but RPI3 indeed has a file /sys/class/gpio/gpiochip0, in which
// case that one is the right one to use
string nullFile = $"/sys/class/gpio/gpiochip0";
string nullFile = Path.Combine(GpioBasePath, "gpiochip0");
GpioChipInfo temp;
if (Directory.Exists(nullFile))
{