[Foundation] Fix nullability in NSUbiquitousKeyValueStore. #24278
Conversation
This is file 16 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Made indexer return types nullable (NSObject?) since ObjectForKey can return null - Replaced "To be added." XML documentation with proper documentation for all members - Added see cref attributes for better cross-referencing - Removed unnecessary whitespace in XML comments - Added comprehensive documentation for all Set* methods explaining their purpose Contributes towards #17285.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR enables nullable reference types for NSUbiquitousKeyValueStore and replaces placeholder documentation with proper XML documentation for all public members.
- Enabled nullable reference types by adding
#nullable enable - Made indexer return types nullable (
NSObject?) sinceObjectForKeycan return null - Added comprehensive XML documentation for indexers and all
Set*methods, replacing "To be added" placeholders
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Foundation/NSUbiquitousKeyValueStore.cs | Enabled nullability and added proper documentation for indexers and Set* methods |
| tests/cecil-tests/Documentation.KnownFailures.txt | Removed the two indexer properties that now have proper documentation |
…ullability-16-nsubiquitouskeyvaluestore
✅ [PR Build #825b318] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #825b318] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #825b318] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #825b318] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #825b318] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #825b318] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #825b318] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #825b318] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #825b318] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 130 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 16 of 47 files with nullability disabled in Foundation.
Changes:
Contributes towards #17285.