-
Notifications
You must be signed in to change notification settings - Fork 548
[tests] Fix test variations for monotouch-test. #24280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
These test variations need to go in the shared list of test variations, because they contains conditional compilation symbols that need to be set for referenced projects as well. Also a few other improvements: * Order the test variations identically between the item group with descriptions and the property groups. * Add a sanity check to verify that if a test variation is specified, then something actually happens. * Use 'TrimMode' instead of 'LinkMode'+'MtouchLink' - this avoids forgetting to set either 'LinkMode' or 'MtouchLink'.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #c950c1f] Build passed (Build macOS tests) ✅Pipeline on Agent |
❌ [CI Build #c950c1f] Tests on macOS arm64 - Mac Tahoe (26) failed ❌Tests on macOS arm64 - Mac Tahoe (26) failed for unknown reasons. Pipeline on Agent |
💻 [CI Build #c950c1f] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #c950c1f] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #c950c1f] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #c950c1f] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
🔥 [CI Build #c950c1f] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 115 tests passed. Failures❌ dotnettests tests (iOS)
Html Report (VSDrops) Download ❌ introspection tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
…h-test-variations
✅ [CI Build #970419d] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #970419d] Build passed (Detect API changes) ✅Pipeline on Agent |
These test variations need to go in the shared list of test variations,
because they contains conditional compilation symbols that need to be set for
referenced projects as well.
Also a few other improvements: