-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Windows] Fixed SearchHandler issues #29520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Windows] Fixed SearchHandler issues #29520
Conversation
Hey there @@Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues with the Windows SearchHandler by ensuring that all SearchHandler properties are properly applied to the native control. The changes include updates to extension methods for handling SearchHandler properties, new event subscriptions in the ShellItemHandler for Windows, and corresponding test cases to validate the behavior.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29493.cs | Added automated test case to verify SearchHandler values. |
src/Controls/tests/TestCases.HostApp/Issues/Issue29493.cs | Updated host application to invoke SearchHandler property updates via a button click. |
src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs | Introduced new extension methods that update various SearchHandler properties for Windows. |
src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs | Revised event handling and property change handling to reflect the added SearchHandler updates. |
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs:11
- There appears to be a spelling mistake in 'TextTransformUtilites'; it is likely intended to be 'TextTransformUtilities'.
platformControl.Text = TextTransformUtilites.GetTransformedText(inputView.Text, inputView.TextTransform);
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #29493
Tested the behaviour in the following platforms
Screenshot
Before-Fix.mp4
After-Fix.mp4