Android: reduce Java to .NET layout pass calls (alternative) #31776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
albyrock87
force-pushed
the
reduce-layout-pass-java-to-dotnet-jni-calls-alternative
branch
from
d0585b5 to
ef1385d
Compare
albyrock87
force-pushed
the
reduce-layout-pass-java-to-dotnet-jni-calls-alternative
branch
from
ef1385d to
cf81c7a
Compare
albyrock87
commented
Sep 26, 2025
| import android.view.ViewGroup; | ||
|
|
||
| public abstract class PlatformContentViewGroup extends ViewGroup { | ||
| public abstract class PlatformContentViewGroup extends PlatformViewGroup { |
There was a problem hiding this comment.
@rmarinho is this a change doable during .NET10 SRs cycle or should I prepare a PR to do this now?
I think this is feasible even later... PlatformViewGroup is a ViewGroup so I'm not causing any API change.
An all PlatformViewGroup members will be internal.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
added
area-layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is an alternative for #31595 which aims to further reduce java interop.
Instead of preparing the measure for the actual
Android.Views.View.Measurecall, we invoke a custom measure method which eventually returns a special flag telling us whether a measure is needed.If it is, we run the cross-platform-layout measure method and store the result by using an internal
OverrideMeasuredDimension.Benchmarks
Benchmarks are totally unreliable, I tried multiple times and I always get different results.