Provided Fill property support for BoxView control

[NirmalKumarYuvaraj]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This pull request adds support for the Fill property to the BoxView control, allowing it to be filled with any Brush (including gradients), not just a solid color. It introduces the necessary property, binding, event handling, and updates to tests and sample code to demonstrate and validate the new functionality.

The most important changes are:

BoxView Fill Property Implementation:

• Added a new bindable property FillProperty and corresponding Fill getter/setter to BoxView, enabling the use of any Brush (such as gradients) to fill the box. The property includes logic to manage event subscriptions for brush changes and resource updates. (src/Controls/src/Core/BoxView/BoxView.cs) [1] [2] [3] [4]
• Updated the implementation of the IShapeView.Fill property to prioritize the new Fill property over the existing Color property. (src/Controls/src/Core/BoxView/BoxView.cs)

Event Handling and Resource Management:

• Introduced the WeakBrushChangedProxy helper class to manage weak event subscriptions for brush property changes, ensuring proper resource cleanup and preventing memory leaks. (src/Controls/src/Core/Internals/WeakEventProxy.cs, moved from src/Controls/src/Core/Shapes/Shape.cs) [1] [2]
• Ensured event handlers and resource listeners are added/removed as the Fill property changes, and cleaned up in the BoxView destructor. (src/Controls/src/Core/BoxView/BoxView.cs) [1] [2]

Public API Updates:

• Registered the new Fill property and its accessors in the public API files for all supported platforms. [1] [2] [3] [4] [5] [6]

Test and Sample Enhancements:

• Updated the BoxView sample view model and test page to support and demonstrate the new Fill property, including options for solid, linear, and radial gradient fills, and corresponding UI controls. (src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewControlPage.xaml, src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewViewModel.cs) [1] [2] [3] [4] [5]

Code Cleanup:

• Removed the unused System.ComponentModel import and relocated the WeakBrushChangedProxy class from Shape.cs to a more appropriate location. (src/Controls/src/Core/BoxView/BoxView.cs, src/Controls/src/Core/Shapes/Shape.cs) [1] [2]

Issues Fixed

Fixes #2365

[dotnet-policy-service]

Hey there @@NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[Copilot]

Pull Request Overview

This PR adds support for the Fill property to the BoxView control, enabling it to be filled with any Brush (including gradients) instead of just solid colors. The implementation includes proper event handling, resource management, and comprehensive test coverage.

• Adds a new Fill property to BoxView that accepts any Brush type
• Implements proper event subscription and resource management for brush changes
• Updates the IShapeView.Fill implementation to prioritize the new Fill property over the existing Color property

Reviewed Changes

Copilot reviewed 13 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Controls/src/Core/BoxView/BoxView.cs	Core implementation of the Fill property with event handling and resource management
src/Controls/src/Core/Internals/WeakEventProxy.cs	Adds WeakBrushChangedProxy class for managing brush change subscriptions
src/Controls/src/Core/Shapes/Shape.cs	Removes duplicate WeakBrushChangedProxy class
src/Controls/src/Core/PublicAPI/*/PublicAPI.Unshipped.txt	Updates public API surface for all platforms
src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewViewModel.cs	Adds view model support for Fill property with gradient brushes
src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewControlPage.xaml	Updates UI test page with Fill property binding and controls
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/BoxViewFeatureTests.cs	Adds new UI tests for Fill property functionality

[jsuarezruiz]

/azp run MAUI-UITests-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jsuarezruiz]

Several tests failing on Android:

Around 7-8% difference between snapshots. Could you take a look?

[NirmalKumarYuvaraj]

Several tests failing on Android: Around 7-8% difference between snapshots. Could you take a look?

@jsuarezruiz , I have added the pending snaps for android and mac platforms. There was a issue with windows platform , it does not have anything to do with this PR. it was related to shadow (#31821). Fill is working fine in windows also. attaching images for reference.

Solid	Linear	Radial

[jsuarezruiz]

/azp run MAUI-UITests-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jsuarezruiz]

Pending snapshot on Windows.

BoxView_CornerRadiusWithOpacityAndShadow

[jsuarezruiz]

Pending snapshot on Windows.

BoxView_CornerRadiusWithOpacityAndShadow

Not related with the changes from this PR, but the Shadow not follow the BoxView corners radius.

[NirmalKumarYuvaraj]

Pending snapshot on Windows.
BoxView_CornerRadiusWithOpacityAndShadow

Not related with the changes from this PR, but the Shadow not follow the BoxView corners radius.

@jsuarezruiz , yeah need to restrict this test case too.

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

The implementation allows both Color and Fill to be set simultaneously, with Fill taking priority. This requires updates in the documentation.

[jsuarezruiz]

Also, what happens when Fill is cleared?
<BoxView x:Name="box" Color="Red" Fill="{StaticResource MyGradient}" />

Later in code:

box.Fill = null;

Does Red color suddenly appear? Could we have a test?

[NirmalKumarYuvaraj]

@jsuarezruiz , when fill is set to null , the color takes over. i have added test case to ensure this.