Skip to content

[Testing] Fix Bugzilla41842 test by replacing raw Page with ContentPage #31862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 2 commits into from
Oct 31, 2025
Merged

[Testing] Fix Bugzilla41842 test by replacing raw Page with ContentPage #31862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8195205
Modified the test
Shalini-Ashokan Oct 3, 2025
38dba15
Modified the test case
Shalini-Ashokan Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Controls/tests/TestCases.HostApp/Issues/Bugzilla/Bugzilla41842.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ protected override void Init()
{
FlyoutLayoutBehavior = FlyoutLayoutBehavior.Split;

Flyout = new Page() { Title = "Flyout" };
Flyout = new ContentPage() { Title = "Flyout", Content = new Label { Text = "Flyout Content", AutomationId = "FlyoutLabel" } };

Detail = new NavigationPage(new Page());
Detail = new NavigationPage(new ContentPage());
Detail = new NavigationPage(new ContentPage { Content = new Label { AutomationId = "Success", Text = "Success" } });
}
}
Expand Down
9 changes: 4 additions & 5 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla41842.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,16 @@ public Bugzilla41842(TestDevice testDevice) : base(testDevice)

public override string Issue => "Set FlyoutPage.Detail = New Page() twice will crash the application when set FlyoutLayoutBehavior = FlyoutLayoutBehavior.Split";
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Issue description still references 'New Page()' even though the test now uses ContentPage instances; updating the wording to match the current scenario will avoid confusion.

Suggested change
public override string Issue => "Set FlyoutPage.Detail = New Page() twice will crash the application when set FlyoutLayoutBehavior = FlyoutLayoutBehavior.Split";
public override string Issue => "Set FlyoutPage.Detail = new ContentPage() twice will crash the application when set FlyoutLayoutBehavior = FlyoutLayoutBehavior.Split";

Copilot uses AI. Check for mistakes.

// Crash after navigation
/*
[Test]
[Ignore("The sample is crashing.")]
[Category(UITestCategories.FlyoutPage)]
[Category(UITestCategories.Compatibility)]
[FailsOnAllPlatformsWhenRunningOnXamarinUITest("The sample is crashing. More information: https://github.com/dotnet/maui/issues/21205")]
public void Bugzilla41842Test()
{
#if MACCATALYST
App.WaitForElement("FlyoutLabel");
Copy link
Contributor

@jsuarezruiz jsuarezruiz Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is passing on CI.

#else
App.WaitForElement("Success");
#endif
Comment on lines +20 to +24
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The platform conditional causes different assertions without any in-code explanation; adding a brief comment (e.g., why MacCatalyst cannot validate the Detail label) would improve clarity for future maintainers.

Copilot uses AI. Check for mistakes.
Comment on lines +20 to +24
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On MacCatalyst the test only waits for the Flyout label and never validates that the second Detail assignment (the core of the regression scenario) succeeded; this reduces coverage of the original issue on that platform. Consider asserting both that no crash occurred and that the Detail 'Success' label is eventually present (or document why it cannot be).

Copilot uses AI. Check for mistakes.
}
*/
}
}
Loading