-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Use MicroBuildSigningPlugin from arcade templates and split .vsts-dotnet.yml #12126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use MicroBuildSigningPlugin from arcade templates and split .vsts-dotnet.yml #12126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR switches to using the MicroBuildSigningPlugin via the shared arcade job template and removes the explicit signing and cleanup tasks.
- Adds a
job.yml
template invocation withenableMicrobuild: true
- Removes the manual MicroBuildSigningPlugin task
- Removes the manual MicroBuildCleanup task
Comments suppressed due to low confidence (2)
.vsts-dotnet.yml:95
- Ensure that the
enableMicrobuild: true
parameter in the template covers the signing conditions (e.g.,SignType
checks) previously handled by the explicit task; otherwise, artifacts may be signed when not intended.
- template: /eng/common/templates-official/job/job.yml@self
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the internal job doesn't run and requires some approval, I saw something similar in FR, I guess just ask them to allow it?
Use MicroBuildSigningPlugin from arcade templates
internal run: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=11968230&view=results