Fix embedded resources missing in PublishAot + NoBuild binaries #12791
+19
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12712
Context
PR #10928 added
_GenerateCompileInputsas a dependency to_GenerateCompileDependencyCacheto include embedded resources in incremental build cache. This broke NoBuild publish scenarios: when_GenerateCompileInputsis skipped (MSBuild marks it "Previously built successfully"),_CoreCompileResourceInputsremains unpopulated, causing CoreCompile to produce resource-less DLLs during RID-specific recompilation.Changes Made
Modified
_GenerateCompileDependencyCachetarget inMicrosoft.Common.CurrentVersion.targets:PrepareResourcesdependency to ensureOutputResourcemetadata is set before population logic runs_CoreCompileResourceInputswhen empty, duplicating the logic from_GenerateCompileInputsTesting
Verified with original repro:
dotnet build -p:PublishAot=truefollowed bydotnet publish -p:PublishAot=true -p:NoBuild=trueproduces working binary with embedded resources.Notes
Preserves PR #10928's fast up-to-date check benefit while fixing NoBuild scenarios. The fallback only triggers when
_GenerateCompileInputsis skipped, avoiding duplicate resource additions.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.