[Flaky Test] Quarantine 4 flaky tests - #13937
Conversation
- ToolTask_Tests.OverrideStdOutImportanceToHigh (Windows, tracked by #13934) - ToolTask_Tests.ToolTaskCanChangeCanonicalErrorFormat (Windows, tracked by #13931) - MSBuildTaskHostTests.CompileNet35WinFormsApp (Windows, tracked by #13933) - BinaryLoggerTests.BinaryLoggerShouldEmbedFilesViaTaskOutput (Linux, tracked by #13932) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Quarantines four intermittently failing unit tests by adding [ActiveIssue] attributes scoped to the affected OS, keeping the rest of the test suite running while the linked determinism issues are investigated.
Changes:
- Quarantined two
ToolTask_Testsfailures on Windows via[ActiveIssue(..., TestPlatforms.Windows)]. - Quarantined a .NET 3.5 WinForms task-host test on Windows via
[ActiveIssue(..., TestPlatforms.Windows)]. - Quarantined a BinaryLogger embedding test on Linux via
[ActiveIssue(..., TestPlatforms.Linux)].
Show a summary per file
| File | Description |
|---|---|
| src/Utilities.UnitTests/ToolTask_Tests.cs | Adds Windows-scoped [ActiveIssue] quarantines for two flaky ToolTask-related tests. |
| src/Build.UnitTests/MSBuildTaskHostTests.cs | Adds a Windows-scoped [ActiveIssue] quarantine for the flaky .NET 3.5 WinForms compilation test. |
| src/Build.UnitTests/BinaryLogger_Tests.cs | Adds a Linux-scoped [ActiveIssue] quarantine for intermittent file-embedding verification in binlogs. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
|
|
|
Quarantines 4 tests that are failing intermittently in CI. None could be reproduced on this Linux/.NET runner, so all are quarantined with
[ActiveIssue]pending a determinism fix.Microsoft.Build.UnitTests.ToolTask_Tests.ToolTaskCanChangeCanonicalErrorFormat
Action: Quarantine (7d) —
[ActiveIssue("https://github.com/dotnet/msbuild/issues/13931", TestPlatforms.Windows)]Tracked by #13931
mainbuilds)Assert.Contains() Failure—findstr.exestdout mismatchMicrosoft.Build.UnitTests.ToolTask_Tests.OverrideStdOutImportanceToHigh
Action: Quarantine (7d) —
[ActiveIssue("https://github.com/dotnet/msbuild/issues/13934", TestPlatforms.Windows)]Tracked by #13934
mainbuilds: 1430301, 1431561, 1440318)Assert.Contains() Failure—"hello world"not found in tool stdoutMicrosoft.Build.Engine.UnitTests.MSBuildTaskHostTests.CompileNet35WinFormsApp
Action: Quarantine (7d) —
[ActiveIssue("https://github.com/dotnet/msbuild/issues/13933", TestPlatforms.Windows)]Tracked by #13933
mainbuilds: 1437213, 1445319)[WindowsNet35OnlyFact]); cannot reproduce on Linux.Microsoft.Build.UnitTests.BinaryLoggerTests.BinaryLoggerShouldEmbedFilesViaTaskOutput
Action: Quarantine (7d) —
[ActiveIssue("https://github.com/dotnet/msbuild/issues/13932", TestPlatforms.Linux)]Tracked by #13932
mainbuilds: 1430551, 1431677, 1445471)zipArchive.Entriesdoes not containtesttaskoutputfile.txt— likely a timing/ordering race in task-output file embedding