Skip to content

Analyzers prototype proposal - #9735

Merged
JanKrivanek merged 44 commits into
mainfrom
exp/build-analyzers
Apr 15, 2024
Merged

Analyzers prototype proposal#9735
JanKrivanek merged 44 commits into
mainfrom
exp/build-analyzers

Conversation

@JanKrivanek

@JanKrivanek JanKrivanek commented Feb 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Context

Initial prototype of Analyzers/BuildCop project.
It's currently hidden behind a feature-flag in form of an explicit commandline argument

Design Doc

#9853

ladipro
ladipro reviewed Feb 16, 2024
View reviewed changes

@ladipro ladipro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few comments.

Comment thread src/Analyzers/Microsoft.Build.Analyzers.csproj Outdated
Comment thread src/Analyzers/API/PerformanceWeightClass.cs Outdated
Comment thread src/Analyzers/API/InvocationConcurrency.cs Outdated
Comment thread src/Analyzers/OM/ParsedItemsContext.cs Outdated
@ladipro
ladipro force-pushed the exp/build-analyzers branch from ab5267f to 90bc89c Compare February 19, 2024 11:05
@JanKrivanek
JanKrivanek marked this pull request as ready for review February 20, 2024 15:01
@JanKrivanek
JanKrivanek requested a review from a team as a code owner February 20, 2024 15:01
rainersigwald
rainersigwald reviewed Feb 20, 2024
View reviewed changes

@rainersigwald rainersigwald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at everything yet.

Comment thread src/UnitTests.Shared/RunnerUtilities.cs Outdated
Comment thread src/Build/BuildCop/API/BuildAnalyzer.cs Outdated
Comment thread eng/BootStrapMSBuild.targets Outdated
Comment thread eng/cibuild_bootstrapped_msbuild.ps1 Outdated
Comment thread src/Analyzers.UnitTests/BootstrapRunner.cs Outdated
Comment thread src/Build/BuildCop/Analyzers/SharedOutputPathAnalyzer.cs
Comment thread src/Build/BuildCop/Analyzers/SharedOutputPathAnalyzer.cs Outdated
Comment thread src/Build/BuildCop/API/BuildAnalyzerResult.cs Outdated
Comment thread src/Analyzers.UnitTests/EndToEndTests.cs Outdated
Comment thread src/Build/BuildCop/Infrastructure/BuildCopConnectorLogger.cs Outdated
@ladipro ladipro mentioned this pull request Feb 21, 2024
Closed
f-alizada
f-alizada reviewed Feb 29, 2024
View reviewed changes
Comment thread src/Build/BuildCop/Infrastructure/ConfigurationProvider.cs
This was referenced Apr 27, 2026
Closed
Closed
Closed
Closed
This was referenced May 7, 2026
Closed
Closed
This was referenced May 15, 2026
Closed
Closed
Merged
@dependabot dependabot Bot mentioned this pull request May 27, 2026
Closed
This was referenced Jun 10, 2026
Closed
Closed
This was referenced Jun 20, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jul 1, 2026
Closed
This was referenced Jul 10, 2026
Closed
Closed
Closed
Closed
This was referenced Jul 20, 2026
Closed
Closed
Closed
This was referenced Jul 27, 2026
Merged
Merged
This was referenced Aug 7, 2026
Closed
Merged
Merged
@dependabot dependabot Bot mentioned this pull request Aug 14, 2026
Open
39 tasks
This was referenced Aug 29, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes
@rainersigwald rainersigwald Awaiting requested review from rainersigwald
@ladipro ladipro Awaiting requested review from ladipro
+2 more reviewers
@maridematte maridematte maridematte approved these changes
@f-alizada f-alizada f-alizada approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JanKrivanek @YuliiaKovalova @rainersigwald @maridematte @ladipro @f-alizada