fix: use explicit address equality - #10257
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Use Equals for IPAddress and SiloAddress comparisons across networking, placement, and diagnostics so comparisons invoke the intended value equality overload. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 56caa2ba-bee6-450b-b29b-da02b0541333
ReubenBond
force-pushed
the
fix/silo-address-equality
branch
from
July 10, 2026 03:12
4dc1ead to
61858ca
Compare
This was referenced Jul 22, 2026
This was referenced Jul 29, 2026
This was referenced Jul 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some address comparisons can bind to an unintended equality overload when written with == or !=. Use explicit Equals calls for IPAddress and SiloAddress comparisons across networking, placement, and diagnostics.
This PR is stacked on #10256 so the commits appear in the same order as the dissemination branch; merge the parsing PR first.
Microsoft Reviewers: Open in CodeFlow