test: wait for grain call before checking cancellation - #10319
Merged
ReubenBond merged 1 commit intoAug 1, 2026
Merged
Conversation
Ensure delayed cancellation cases observe that the grain method has started before expecting its catch block to record cancellation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44628696-d4d6-43f1-802d-dcf7a0d8952a
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the delayed cancellation path in CancellationTokenTests deterministic by adding an explicit “call started” handshake emitted from inside the grain method, avoiding cases where cancellation can occur before the grain method runs on slower activation paths.
Changes:
- Update the cancellation test to wait for an in-method start notification before scheduling delayed cancellation.
- Introduce a test-only grain observer interface and an observer implementation to signal when the grain method begins executing.
- Add a new grain method wrapper which notifies the observer before delegating to the existing long-wait implementation.
Show a summary per file
| File | Description |
|---|---|
| test/Orleans.Runtime.Tests/CancellationTests/CancellationTokenTests.cs | Waits for an explicit “call started” signal before scheduling delayed cancellation, making the test deterministic on slow activation paths. |
| test/Grains/TestGrains/GenericGrains.cs | Adds a grain method which notifies an observer that execution has started, then calls the existing long-wait path. |
| test/Grains/TestGrainInterfaces/IGenericInterfaces.cs | Adds a test observer interface and a new grain method signature to support the start-notification handshake. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
This was referenced Aug 28, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delayed grain cancellation test assumed that a positive timer meant the grain method had started. On slower activation paths, cancellation can remove the request from the activation's waiting queue and return
OperationCanceledExceptionwithout invoking the method, leaving the test waiting for a cancellation record which can never be written.Add a test observer handshake emitted from inside the grain method and wait for it before scheduling delayed cancellation. This preserves immediate-cancellation coverage while making the delayed cases deterministically exercise cancellation of a running call. No runtime product behavior is changed.
Microsoft Reviewers: Open in CodeFlow