Skip to content

fix(telemetry)!: update RPC semantic convention keys - #10354

Merged
ReubenBond merged 3 commits into
dotnet:mainfrom
rkargMsft:rkargmsft-adjust-semantic-conventions
Aug 8, 2026
Merged

ReubenBond merged 3 commits into
dotnet:mainfrom
rkargMsft:rkargmsft-adjust-semantic-conventions

Conversation

@rkargMsft

@rkargMsft rkargMsft commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Updates Orleans RPC activity attributes to the current OpenTelemetry semantic conventions. Replaces legacy and reserved-namespace keys, preserves Orleans service/target/source metadata under the Orleans namespace, versions the affected ActivitySources, and adds regression coverage.

Semantic Convention for non-standard attributes is to prefix with something company or product specific. Using orleans.** which is also a pattern in use for other existing attributes.

Fixes #10320

rkarg-blizz and others added 2 commits August 7, 2026 10:42
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@rkargMsft
rkargMsft force-pushed the rkargmsft-adjust-semantic-conventions branch from 92633b5 to 29ff950 Compare August 7, 2026 17:42
@rkargMsft
rkargMsft requested a review from ReubenBond August 7, 2026 18:08
@rkargMsft
rkargMsft enabled auto-merge August 7, 2026 20:35
@ReubenBond ReubenBond changed the title fix(telemetry): update RPC semantic convention keys fix(telemetry)!: update RPC semantic convention keys Aug 7, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ReubenBond

Copy link
Copy Markdown
Member

Pushed bb756333e to fully qualify the rpc.method attribute as <interface>/<method>. The current OpenTelemetry RPC semantic conventions deprecate the separate rpc.service attribute and require the logical service name to be included in rpc.method; emitting only the method name would leave the updated telemetry non-conformant. The regression test now verifies the fully qualified value.

@rkargMsft

Copy link
Copy Markdown
Contributor Author

Pushed bb756333e to fully qualify the rpc.method attribute as <interface>/<method>. The current OpenTelemetry RPC semantic conventions deprecate the separate rpc.service attribute and require the logical service name to be included in rpc.method; emitting only the method name would leave the updated telemetry non-conformant. The regression test now verifies the fully qualified value.

In that case then do we need the orleans.rpc.service attribute?

@ReubenBond
ReubenBond disabled auto-merge August 8, 2026 00:42
@ReubenBond
ReubenBond merged commit 0cd34e5 into dotnet:main Aug 8, 2026
66 of 67 checks passed
This was referenced Aug 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust to current Semantic Conventions (https://opentelemetry.io/docs/specs/semconv/rpc/)

3 participants