fix(transactions): isolate failed storage writes - #10375
Merged
ReubenBond merged 1 commit intoAug 10, 2026
Merged
Conversation
ReubenBond
added a commit
to ReubenBond/orleans
that referenced
this pull request
Aug 8, 2026
Remove direct wrapper coverage which is already provided by upstream PR dotnet#10375, keeping this change focused on the storage contract and shared TestKit coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ReubenBond
added a commit
to ReubenBond/orleans
that referenced
this pull request
Aug 9, 2026
Remove direct wrapper coverage which is already provided by upstream PR dotnet#10375, keeping this change focused on the storage contract and shared TestKit coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
reubenbond-fix-transaction-storage-writes
branch
from
August 9, 2026 00:03
19d5318 to
5fff8a8
Compare
This was referenced Aug 28, 2026
Merged
Merged
This was referenced Sep 4, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed transactional state writes could leave speculative metadata, pending states, and committed state in the wrapper's cached record, allowing later same-instance operations to observe or persist changes which were not durably confirmed.
This change constructs each write as a copy-on-write candidate and only retains it after the storage provider completes with a valid ETag. Failed or ambiguous writes restore the previously loaded record and ETag, preserving safe retry and load-based recovery semantics across storage providers. Focused tests cover failed-write reuse, speculative mutation isolation, ambiguous-write recovery, strict ETag handling, no-change writes, and successful prepare/abort/commit behavior.
Microsoft Reviewers: Open in CodeFlow