Skip to content

fix(zookeeper): tolerate transient connection loss #10437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 1 commit into from
Aug 11, 2026
Merged

fix(zookeeper): tolerate transient connection loss #10437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Orleans.Clustering.ZooKeeper/ZooKeeperBasedMembershipTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public partial class ZooKeeperBasedMembershipTable : IMembershipTable
{
private readonly ILogger logger;

private const int ZOOKEEPER_CONNECTION_TIMEOUT = 2000;
private const int ZOOKEEPER_SESSION_TIMEOUT = 10_000;

private readonly ZooKeeperWatcher watcher;

Expand Down Expand Up @@ -297,12 +297,12 @@ private static async Task<Tuple<MembershipEntry, string>> GetRow(ZooKeeper zk, S

private static Task<T> UsingZookeeper<T>(Func<ZooKeeper, Task<T>> zkMethod, string deploymentConnectionString, ZooKeeperWatcher watcher, bool canBeReadOnly = false)
{
return ZooKeeper.Using(deploymentConnectionString, ZOOKEEPER_CONNECTION_TIMEOUT, watcher, zkMethod, canBeReadOnly);
return ZooKeeper.Using(deploymentConnectionString, ZOOKEEPER_SESSION_TIMEOUT, watcher, zkMethod, canBeReadOnly);
}

private Task UsingZookeeper(string connectString, Func<ZooKeeper, Task> zkMethod)
{
return ZooKeeper.Using(connectString, ZOOKEEPER_CONNECTION_TIMEOUT, watcher, zkMethod);
return ZooKeeper.Using(connectString, ZOOKEEPER_SESSION_TIMEOUT, watcher, zkMethod);
}

private static string ConvertToRowPath(SiloAddress siloAddress)
Expand Down
Loading