Stabilize SingleWorkerInvocationUnderLoad test - #9919
Merged
ReubenBond merged 1 commit intoFeb 15, 2026
Merged
ReubenBond merged 1 commit into
ReubenBond merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes a flaky test by replacing timing-based delays with deterministic state polling. The test SingleWorkerInvocationUnderLoad verifies that stateless worker grains maintain a single activation when requests are sequential (no concurrent load). The change improves test reliability by using IManagementGrain.GetGrainActivationCount combined with the Until helper instead of relying on timing assumptions.
Changes:
- Introduced
IManagementGrainto query actual activation counts from the Orleans runtime - Added polling logic using the
Untilhelper to wait for the expected activation count (1) with a 5-second timeout - Preserved the loop structure to verify consistent single-activation behavior across 100 iterations
| { | ||
| var workerGrain = _fixture.GrainFactory.GetGrain<IStatelessWorkerScalingGrain>(0); | ||
| var managementGrain = _fixture.GrainFactory.GetGrain<IManagementGrain>(0); | ||
| var grainReference = (GrainReference)workerGrain; |
There was a problem hiding this comment.
The GrainReference type requires a using Orleans.Runtime; directive at the top of the file. Without it, this code will not compile. Note that the same issue affects existing code at lines 150, 156, and 165 in the CatalogCleanupOnDeactivation test.
ReubenBond
enabled auto-merge
February 15, 2026 15:13
Replace timing-based delay in SingleWorkerInvocationUnderLoad with state-based polling via IManagementGrain activation count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
copilot/fix-single-worker-invocation-flake-20260215-142235
branch
from
February 15, 2026 17:01
c52ac6f to
ceeaabc
Compare
ReubenBond
disabled auto-merge
February 15, 2026 17:18
ReubenBond
enabled auto-merge
February 15, 2026 20:57
ReubenBond
disabled auto-merge
February 15, 2026 20:57
ReubenBond
deleted the
copilot/fix-single-worker-invocation-flake-20260215-142235
branch
February 15, 2026 20:57
ReubenBond
added a commit
that referenced
this pull request
Feb 15, 2026
Stabilize stateless worker activation test Replace timing-based delay in SingleWorkerInvocationUnderLoad with state-based polling via IManagementGrain activation count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
Stabilize stateless worker activation test Replace timing-based delay in SingleWorkerInvocationUnderLoad with state-based polling via IManagementGrain activation count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SingleWorkerInvocationUnderLoadwith deterministic state pollingIManagementGrain.GetGrainActivationCountplus the existingUntilhelper to wait for a single activationTesting
Microsoft Reviewers: Open in CodeFlow