-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix CS1003 error message when expression follows identifier without '=' #81285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
27
commits into
main
Choose a base branch
from
copilot/fix-variable-declaration-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
9c2c794
Initial plan
Copilot bc76ea7
Fix CS1003 error message to suggest '=' when literal follows identifier
Copilot eb24d70
Add WorkItem attribute to test methods for issue #44292
Copilot 6018aa5
Extend parser fix to handle all expressions and use raw string literals
Copilot 2ed35f5
Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs
CyrusNajmabadi 05ca746
Remove IsTrueIdentifier check and add OpenBraceToken handling
Copilot 4806bf7
Add documentation for comprehensive manual test verification
Copilot ba3c97e
Fix comma/semicolon/equals check to apply only for identifiers
Copilot 1affc1b
Remove incorrect comment and add proper manual verification documenta…
Copilot 804703f
Simplify
CyrusNajmabadi 9444e48
Merge branch 'copilot/fix-variable-declaration-issue' of https://gith…
CyrusNajmabadi 138ba72
Fix check
CyrusNajmabadi a86561d
Add actual tests for unary, binary, and object creation expressions
Copilot 67b2d89
Fix check
CyrusNajmabadi c823254
Merge branch 'copilot/fix-variable-declaration-issue' of https://gith…
CyrusNajmabadi f6f16d3
Add testss
CyrusNajmabadi 410ba8a
Fixup
CyrusNajmabadi 6ecd0f5
Simplify impl
CyrusNajmabadi bb5b40b
Update tests
CyrusNajmabadi 9ec48ac
Update tests
CyrusNajmabadi c6a0d04
Fix test
CyrusNajmabadi 5abb35e
Update test
CyrusNajmabadi 7dde080
REvert
CyrusNajmabadi 4a2161f
Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs
CyrusNajmabadi 4c3122b
Add assert
CyrusNajmabadi 6fcd389
Merge branch 'copilot/fix-variable-declaration-issue' of https://gith…
CyrusNajmabadi cd1b2ff
Fix test
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.