Bump Roslyn to 5.0 - #1787
Merged
Merged
Conversation
josefpihrt
added a commit
that referenced
this pull request
Aug 8, 2026
Update README, SECURITY, and NuGet readmes for Roslynator 2026. Keep Visual Studio 2022 config paths for upgrade compatibility. Remove unused analyzer code-fix refs from VS Code build project. Ignore .vscode-test download folder from extension tests. Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
marked this pull request as draft
August 8, 2026 18:15
josefpihrt
force-pushed
the
feature/roslyn-5
branch
from
August 8, 2026 18:19
a1fdc1a to
ce956e1
Compare
2 tasks
josefpihrt
commented
Aug 14, 2026
josefpihrt
left a comment
Collaborator
Author
There was a problem hiding this comment.
Detailed review of the Roslyn 5.0 / Roslynator 2026 migration. The toolchain bump, roslyn5.0 pack flavor, GetDeclaredLocalSymbol helper, RegisterWorkspaceFailedHandler, and dropping bundled analyzers from both IDEs are directionally right. A few product/docs mismatches should be fixed before this leaves draft — especially analyzer “Applies to” docs and NuGet requirements still describing the old VSIX-includes-analyzers world.
Also: this branch last moved on 8 Aug and will need a rebase onto current main (extension-block / SyntaxKind.ExtensionDeclaration work in particular).
Drop IDE bullets from analyzer Applies-to docs, keep NuGet VS 2022/2026 requirements, remove RCS code-fix MEF from the VSIX, and fix EquivalenceKey filtering, deconstruction UseExplicitType, and ROSLYN_5_0_ONLY on the default build. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Pushed review follow-ups in f83af69:
|
josefpihrt
marked this pull request as ready for review
August 16, 2026 13:17
Align marketplace and NuGet copy with analyzers-via-NuGet messaging, and keep Roslynator 2022 linked where Roslynator 2026 is mentioned. Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
pushed a commit
that referenced
this pull request
Aug 16, 2026
The Unreleased #1787 bullet conflicted with the testing-package floor at 3.8.0. CLI still targets 5.0.0; this repo's suite still runs at 5.0.0. Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
added a commit
that referenced
this pull request
Aug 16, 2026
…mework (#1810) * feat(testing): let consumers choose the Roslyn version Lower the Roslyn dependency of the testing packages to 3.8.0 so the effective Roslyn version is determined by the consumer's own Microsoft.CodeAnalysis.* reference instead of being forced to a fixed version. - Decouple Roslynator.Testing.Common from the Roslynator.Core package by duplicating the handful of internal helpers it used. - Add RoslynatorTestRoslynVersion so this repo's own test suite can run against a chosen Roslyn version; add a CI run at 4.7.0. - Guard version-sensitive tests so the suite builds and passes at 4.7.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: add PR link for testing framework change in changelog Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: clarify testing-framework Roslyn version CI and 4.4 define Co-authored-by: Cursor <cursoragent@cursor.com> * docs: address PR 1810 review on testing Roslyn floor Move the Testing Framework changelog entry to Breaking (including the Core reference break), centralize ROSLYN_TEST_* defines for all test projects, and clarify Default vs Latest parse LanguageVersion in the NuGet readmes. Also pin RoslynatorTestRoslynVersion to 5.0.0 after the Roslyn 5.0 merge and drop the incompatible 4.7 test matrix cell. Co-authored-by: Cursor <cursoragent@cursor.com> * chore: remove obsolete test_roslyn_versions note from CI Co-authored-by: Cursor <cursoragent@cursor.com> * docs: stop saying the testing library targets Roslyn 5.0 The Unreleased #1787 bullet conflicted with the testing-package floor at 3.8.0. CLI still targets 5.0.0; this repo's suite still runs at 5.0.0. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Josef Pihrt <josef.pihrt@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 26, 2026
Merged
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking release: migrate Roslynator to Roslyn 5.0.0 and retarget IDE extensions for the Roslyn 5 toolchain.
roslyn5.0NuGet package flavor (analyzers/dotnet/roslyn5.0/cs) alongside existingroslyn3.8androslyn4.7[18.0,19.0))Roslynator.AnalyzersNuGet for diagnostics and RCS fixes)Breaking changes
Extension behavior
Visual Studio 2026
Roslynator.AnalyzersNuGetVS Code (OmniSharp required;
dotnet.server.useOmnisharp:true)Technical notes
GetDeclaredLocalSymbol,RegisterWorkspaceFailedHandler, null-safety updatesMicrosoft.Build17.11.31 minimum for Roslyn 5Workspaces.MSBuildMicrosoft.VisualStudio.SDK17.14 +Microsoft.VSSDK.BuildTools18.9RS1038suppressed on analyzer projects (VB-capable assemblies; tech debt)Test plan
dotnet teston Roslyn 5.0roslyn3.8,roslyn4.7,roslyn5.0)build_vs_extension(VS 2026 VSIX)