fix(analyzers): skip RCS1231 for sync Task-returning methods - #1802
Merged
josefpihrt merged 3 commits intoAug 14, 2026
Conversation
Fixes #1702 Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
commented
Aug 11, 2026
1 task
…methods Keep suggesting `in` for other readonly structs on Task-returning methods, and reuse the existing GetDeclaredSymbol lookup in Analyze. Co-authored-by: Cursor <cursoragent@cursor.com>
josefpihrt
deleted the
fix/analyzers/rcs1231-sync-task-cancellationtoken
branch
August 14, 2026 19:23
This was referenced Aug 16, 2026
Closed
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncexemption by skipping sync methods and local functions that return well-known task types (Task,Task<T>,ValueTask,ValueTask<T>)CancellationTokenin sync methods likereturn Task.FromCanceled(cancellationToken)Fixes #1702
Test plan
dotnet test src/Tests/Analyzers.Tests/Analyzers.Tests.csproj --filter "FullyQualifiedName~RCS1231"Made with Cursor