All the test templates that verify the invalid immediate, is missing this piece of code. Thanks @amanasifkhalid for bringing this to my attention in #104697 (comment).
if (!succeeded)
{
Succeeded = false;
}
There are also certain templates like _SveImmBinaryOpTestTemplate.template that doesn't even have this test method.
- Need to audit all the
*Imm*.template files that were added/updated as part of SVE work and make sure we add test coverage for it.
- Also make sure that we have coverage for following:
- When we use valid value via constant as the input using
{Imm}
- When we use valid value via variable as the input using
Imm
- When we use invalid valid via constant as the input and we throw
ArgumentOutOfRangeException
- When we use invalid value via variable as the input and we throw
ArgumentOutOfRangeException
All the test templates that verify the invalid immediate, is missing this piece of code. Thanks @amanasifkhalid for bringing this to my attention in #104697 (comment).
There are also certain templates like
_SveImmBinaryOpTestTemplate.templatethat doesn't even have this test method.*Imm*.templatefiles that were added/updated as part of SVE work and make sure we add test coverage for it.{Imm}ImmArgumentOutOfRangeExceptionArgumentOutOfRangeException