Entrypoint verification should work on Apple platforms

[vcsjones]

If you add a new entry point in the unix shims, but forget to add it to entrypoints.c, you get a nice build error:

EXEC : error : /workspaces/runtime/src/libraries/Native/Unix/System.Security.Cryptography.Native/entrypoints.c file did not match entries exported from /workspaces/runtime/artifacts/obj/native/net6.0-Linux-Debug-x64/System.Security.Cryptography.Native/libSystem.Security.Cryptography.Native.OpenSsl.so [/workspaces/runtime/src/libraries/Native/build-native.proj]
  DIFFERENCES FOUND: 
  CryptoNative_Foob
  ninja: build stopped: subcommand failed.

This does not appear to work for macOS. Adding a new exported function and omitting it from entrypoints.c does not fail the build.

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

---

If you add a new entry point in the unix shims, but forget to add it to entrypoints.c, you get a nice build error:

EXEC : error : /workspaces/runtime/src/libraries/Native/Unix/System.Security.Cryptography.Native/entrypoints.c file did not match entries exported from /workspaces/runtime/artifacts/obj/native/net6.0-Linux-Debug-x64/System.Security.Cryptography.Native/libSystem.Security.Cryptography.Native.OpenSsl.so [/workspaces/runtime/src/libraries/Native/build-native.proj]
  DIFFERENCES FOUND: 
  CryptoNative_Foob
  ninja: build stopped: subcommand failed.

This does not appear to work for macOS. Adding a new exported function and omitting it from entrypoints.c does not fail the build.

Author:	vcsjones
Assignees:	-
Labels:	area-System.Security, untriaged
Milestone:	-

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

If you add a new entry point in the unix shims, but forget to add it to entrypoints.c, you get a nice build error:

EXEC : error : /workspaces/runtime/src/libraries/Native/Unix/System.Security.Cryptography.Native/entrypoints.c file did not match entries exported from /workspaces/runtime/artifacts/obj/native/net6.0-Linux-Debug-x64/System.Security.Cryptography.Native/libSystem.Security.Cryptography.Native.OpenSsl.so [/workspaces/runtime/src/libraries/Native/build-native.proj]
  DIFFERENCES FOUND: 
  CryptoNative_Foob
  ninja: build stopped: subcommand failed.

This does not appear to work for macOS. Adding a new exported function and omitting it from entrypoints.c does not fail the build.

Author:	vcsjones
Assignees:	-
Labels:	area-Infrastructure-libraries, area-System.Security, untriaged
Milestone:	-

[vcsjones]

I implemented this, and there are a number of crypto things that are not in entrypoints.c:

AppleCryptoNative_DigestReset,AppleCryptoNative_EcdhKeyAgree,AppleCryptoNative_SecKeychainEnumerateCerts,AppleCryptoNative_SslCopyCADistinguishedNames,AppleCryptoNative_SslCopyCertChain,AppleCryptoNative_SslIsHostnameMatch,AppleCryptoNative_SslRead,AppleCryptoNative_SslSetBreakOnClientAuth,AppleCryptoNative_SslSetBreakOnServerAuth,AppleCryptoNative_SslSetIoCallbacks,AppleCryptoNative_SslWrite,AppleCryptoNative_X509ChainCreate,AppleCryptoNative_X509DemuxAndRetainHandle,AppleCryptoNative_X509GetPublicKey,AppleCryptoNative_X509StoreAddCertificate,AppleCryptoNative_X509StoreRemoveCertificate

Should this be fixed?

[jkotas]

cc @VSadov

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

---

If you add a new entry point in the unix shims, but forget to add it to entrypoints.c, you get a nice build error:

EXEC : error : /workspaces/runtime/src/libraries/Native/Unix/System.Security.Cryptography.Native/entrypoints.c file did not match entries exported from /workspaces/runtime/artifacts/obj/native/net6.0-Linux-Debug-x64/System.Security.Cryptography.Native/libSystem.Security.Cryptography.Native.OpenSsl.so [/workspaces/runtime/src/libraries/Native/build-native.proj]
  DIFFERENCES FOUND: 
  CryptoNative_Foob
  ninja: build stopped: subcommand failed.

This does not appear to work for macOS. Adding a new exported function and omitting it from entrypoints.c does not fail the build.

Author:	vcsjones
Assignees:	-
Labels:	area-Infrastructure-libraries, area-Single-File, untriaged
Milestone:	-

[VSadov]

Yes, the idea is that it should work on all platforms. I do not remember if there was a reason why this does not work on OSX.

And the mismatches need to be fixed.

[VSadov]

It is possible that when validation script was switched from Python to bash, it stopped working on OSX.

[VSadov]

@vcsjones -

I implemented this, and there are a number of crypto things that are not in entrypoints.c:

Did you implement the part that enables verify-entrypoints.sh to work on OSX and now see the failures, or added those new functions?