Uri.IsBaseOf(bool) not true by user info

[osjimenez]

Description

When check a Uri with same info except UserInfo, IsBaseOf method must be return true, as say in documentation

When comparing two Uri objects to determine a base relationship, the user information (UserInfo) is not evaluated

But this behavior does not occur in my case :(

Reproduction Steps

Assert.True(new Uri("https://user@domain.com").IsBaseOf(new("https://domain.com")));

Expected behavior

Return true

Actual behavior

Return false

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

When check a Uri with same info except UserInfo, IsBaseOf method must be return true, as say in documentation

When comparing two Uri objects to determine a base relationship, the user information (UserInfo) is not evaluated

But this behavior does not occur in my case :(

Reproduction Steps

Assert.True(new Uri("https://user@domain.com").IsBaseOf(new("https://domain.com")));

Expected behavior

Return true

Actual behavior

Return false

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	osjimenez
Assignees:	-
Labels:	area-System.Net
Milestone:	-

[karelz]

I can reproduce it even with 2 different UserInfos:

Console.WriteLine(new Uri("https://user@domain.com").IsBaseOf(new("https://user2@domain.com"))); // Returns False

It also reproduces on .NET Framework 4.8, so not a regression, or blocker for migration.
I think it is a bug and should behave as documentation suggests. Moving to Future.

[MihaZupan]

Looking at the implementation, it's clear that UserInfo isn't being ignored at all.
The change to do so should be pretty straightforward (probably just tweak which components we look at), assuming we want to make it.

runtime/src/libraries/System.Private.Uri/src/System/UriExt.cs

Lines 894 to 905 in 4e48d2d

	// Canonicalize and test for substring match up to the last path slash
	string self = GetParts(UriComponents.AbsoluteUri & ~UriComponents.Fragment, UriFormat.SafeUnescaped);
	string other = uriLink.GetParts(UriComponents.AbsoluteUri & ~UriComponents.Fragment, UriFormat.SafeUnescaped);
	unsafe
	{
	fixed (char* selfPtr = self)
	{
	fixed (char* otherPtr = other)
	{
	return UriHelper.TestForSubPath(selfPtr, self.Length, otherPtr, other.Length,
	IsUncOrDosPath || uriLink.IsUncOrDosPath);