Tar: support GNU numeric format. - #101172
Conversation
The tar specification stores numeric fields using an octal representation. This limits the range of values that can be stored. To increase the supported range, a GNU extension defines that when the leading byte is 0xff/0x80 the remaining bytes are a negative/positive big endian formatted value. When writing under the PAX format, we continue to only use the only octal representation in the header fields. The values are overridden using extended attributes.
|
Test failures are unrelated. |
|
@dotnet/area-system-formats-tar ptal. |
|
@carlossanlop ptal. |
|
@dotnet/area-system-formats-tar ptal. |
|
It would be nice to get this in for .NET 9. The sooner tar implementation matures the better for the ecosystem. Thanks for this @tmds! 👍 |
carlossanlop
left a comment
There was a problem hiding this comment.
Thanks for this change. I left some questions. Haven't gone through the whole PR yet.
We also need to run runtime-extra-platforms tests.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@carlossanlop I have addressed your feedback, can you take another look? |
carlossanlop
left a comment
There was a problem hiding this comment.
Thank you for addressing the feedback. I gave it another pass and left some comments for you to consider.
I'll run runtime-extra-platforms now to see if we catch any unexpected errors.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@carlossanlop I've addressed the additional feedback except for the |
|
@carlossanlop can you let me know if you want this test included: #101172 (comment)? |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
left a comment
There was a problem hiding this comment.
Approved pending two things:
- The re-addition of the removed writer-big test case as suggested in the snippet.
- I ran runtime-extra-platforms, which executes tar tests in many other platforms (mobile maybe). Please verify we don't see any new failures related to this change.
|
@carlossanlop can you start another run of runtime-extra-platforms? |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@carlossanlop this is good to merge. |
|
Thanks @tmds! |
|
Considering this is a problem that can be seen in runfo (one of our infrastructure tools) I'm inclined to backport this to .NET 8. Would you have any objections, @ericstj? |
|
Runfo isn't a critical tool, its just for debugging. I'd instead suggest you seek out input from customers reporting this one. See if anyone is blocked on .NET 8.0 - that's more important. This definitely would meet the bar for servicing if we had a customer blocked by it. |
The tar specification stores numeric fields using an octal representation. This limits the range of values that can be stored.
To increase the supported range, a GNU extension defines that when the leading byte is 0xff/0x80 the remaining bytes are a negative/positive big endian formatted value.
When writing under the PAX format, we continue to only use the only octal representation in the header fields. The values are overridden using extended attributes.
Fixes #93763.
@dotnet/area-system-formats-tar ptal.