add PACKAGE.md for System.Formats.Nrbf - #106344
Merged
Merged
Conversation
terrajobst
reviewed
Aug 13, 2024
terrajobst
reviewed
Aug 13, 2024
terrajobst
reviewed
Aug 13, 2024
terrajobst
approved these changes
Aug 13, 2024
terrajobst
left a comment
Contributor
There was a problem hiding this comment.
Left some feedback, but this looks great!
I assume PACKAGE.md is a magic name that nuget.org uses to render as the README?
Co-authored-by: Immo Landwerth <immo@landwerth.net>
Member
Author
My understanding is that we don't use Lines 24 to 26 in bfd964a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
95% of the text was copy pasted from https://learn.microsoft.com/dotnet/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads
5% from the Threat Model doc
fixes #103481