Skip to content

Build NativeAOT-iOS runtime tests as standalone to restore test runs - #107366

Merged
jkoritzinsky merged 2 commits into
dotnet:mainfrom
jkoritzinsky:standalone-smoketests
Sep 5, 2024
Merged

Build NativeAOT-iOS runtime tests as standalone to restore test runs#107366
jkoritzinsky merged 2 commits into
dotnet:mainfrom
jkoritzinsky:standalone-smoketests

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Fixes Issue #107346

cc: @matouskozak

@jkoritzinsky

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike, runtime-ioslikesimulator

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@jkoritzinsky

Copy link
Copy Markdown
Member Author

CI shows the correct tests running again for the NativeAOT legs.

@matouskozak matouskozak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.
fyi: @ivanpovazan @kotlarmilos

@ivanpovazan

Copy link
Copy Markdown
Member

Hey @jkoritzinsky thanks for fixing this quickly!

One thing that is missing, is doing the same for maccatalyst jobs running NativeAOT runtime tests, so adding buildAllTestsAsStandalone: true
to somewhere around here:

creator: dotnet-bot
testBuildArgs: tree nativeaot/SmokeTests /p:BuildNativeAOTRuntimePack=true
testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig)

and here:
creator: dotnet-bot
testBuildArgs: tree nativeaot/SmokeTests /p:BuildNativeAOTRuntimePack=true /p:DevTeamProvisioning=adhoc /p:EnableAppSandbox=true
testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig)

should do the trick.

Failure for reference (from the original failing build): https://dev.azure.com/dnceng-public/public/_build/results?buildId=793084&view=logs&j=c49026c0-42bb-519d-cdde-df21b0e596aa&t=246f45a3-de00-568c-c61c-f424913337a0&l=26

@jkoritzinsky

Copy link
Copy Markdown
Member Author

I'll make sure to do the maccatalyst jobs as well before merging today. Thanks for the heads up!

@jkoritzinsky

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike, runtime-ioslikesimulator, runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jkoritzinsky

Copy link
Copy Markdown
Member Author

/ba-g failures are expected

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Infra][NativeAOT-iOS] Runtime tests workitems not getting sent to helix

3 participants