Skip to content

Fix test bug in FileSystem.Tests - #107696

Merged
jozkee merged 1 commit into
dotnet:mainfrom
jozkee:io_testbug
Sep 12, 2024
Merged

Fix test bug in FileSystem.Tests#107696
jozkee merged 1 commit into
dotnet:mainfrom
jozkee:io_testbug

Conversation

@jozkee

@jozkee jozkee commented Sep 11, 2024

Copy link
Copy Markdown
Member

Fixes #107636.

@jozkee jozkee added this to the 10.0.0 milestone Sep 11, 2024
@jozkee jozkee self-assigned this Sep 11, 2024

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@adamsitnik adamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jozkee !

@jozkee

jozkee commented Sep 12, 2024

Copy link
Copy Markdown
Member Author

/ba-g System.Collections.Specialized.Tests dead-lettered.

@jozkee
jozkee merged commit 01ac168 into dotnet:main Sep 12, 2024
@jozkee
jozkee deleted the io_testbug branch September 12, 2024 21:15
@adamsitnik

Copy link
Copy Markdown
Member

Should we backport it to 9.0 branch?

@jozkee

jozkee commented Sep 13, 2024

Copy link
Copy Markdown
Member Author

@saitama951 doesn't seem to be using the 9.0 branch and looks like we don't have any CI tests running as root so it won't affect CI until we do, that's also why this wasn't caught.

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test cases System.IO.FileSystem

3 participants