Skip to content

System.Net Stress Tests Improvements 2 - #108703

Merged
antonfirsov merged 11 commits into
dotnet:mainfrom
rzikm:stress-improvements-2
Oct 22, 2024
Merged

System.Net Stress Tests Improvements 2#108703
antonfirsov merged 11 commits into
dotnet:mainfrom
rzikm:stress-improvements-2

Conversation

@rzikm

@rzikm rzikm commented Oct 9, 2024

Copy link
Copy Markdown
Member

Fixes #108551.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 9, 2024
@rzikm

rzikm commented Oct 9, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries stress-ssl

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rzikm rzikm added area-System.Net and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 9, 2024
@rzikm
rzikm requested a review from antonfirsov October 9, 2024 11:56
@rzikm rzikm changed the title Stress improvements 2 System.Net Stress Tests Improvements 2 Oct 9, 2024
Comment thread src/libraries/Common/tests/System/Net/StressTests/run-docker-compose.ps1 Outdated
@rzikm
rzikm marked this pull request as ready for review October 10, 2024 11:43
@rzikm

rzikm commented Oct 10, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries stress-ssl

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov

Copy link
Copy Markdown
Contributor

unknown flag: --abort-on-container-exit

Weird, it should be working according to the docs.

Otherwise, the changes look good, but I want to test them locally.

@rzikm

rzikm commented Oct 10, 2024

Copy link
Copy Markdown
Member Author

Otherwise, the changes look good, but I want to test them locally.

on it, I also found out that passing -n to the script does not work for some stupid reason, so there is more work to be done.

@wfurt

wfurt commented Oct 10, 2024

Copy link
Copy Markdown
Member

unknown flag: --abort-on-container-exit

Weird, it should be working according to the docs.

Otherwise, the changes look good, but I want to test them locally.

do we know what docker-compose version runs in CI? I had similar problems in the past when using recently added syntax.

@antonfirsov

antonfirsov commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

One more thing I just noticed, that there is no dumps share volume mounted in the SslStress docker-compose.yml while all the infra for dump sharing seems to be present, we probably want to fix this too.

While there, I think we can also delete the version: 3 lines, to get rid of the docker compose warning.

@rzikm
rzikm force-pushed the stress-improvements-2 branch from 4545fe3 to 03ca742 Compare October 11, 2024 08:27
@rzikm
rzikm removed request for ilonatommy and maraf October 11, 2024 08:27
@rzikm

rzikm commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries stress-ssl

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rzikm

rzikm commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rzikm

rzikm commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

unknown flag: --abort-on-container-exit

It works when run from WSL2 (because it uses the Docker installed in Windows, but my Ubuntu VM I still have to invoke docker-compose (it does not recognize docker compose at all, version 24.0.7)

@antonfirsov

Copy link
Copy Markdown
Contributor

/azp run runtime-libraries stress-ssl

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov

Copy link
Copy Markdown
Contributor

/azp run runtime-libraries stress-ssl

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Doing a final run, just in case, then :shipit:

@antonfirsov
antonfirsov merged commit 1f40b0d into dotnet:main Oct 22, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HttpStress] [SslStress] Not possbile to run locally with docker

3 participants