Skip to content

Define a function prototype for YieldProcessor - #109028

Merged
jkoritzinsky merged 3 commits into
dotnet:mainfrom
jkoritzinsky:minipal-mac-fix
Oct 19, 2024
Merged

Define a function prototype for YieldProcessor#109028
jkoritzinsky merged 3 commits into
dotnet:mainfrom
jkoritzinsky:minipal-mac-fix

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Fixes official build failures.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 18, 2024
Comment thread src/native/minipal/time.c Outdated
@am11 am11 added area-PAL-coreclr only for closed issues and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 18, 2024
@am11

am11 commented Oct 18, 2024

Copy link
Copy Markdown
Member

I think minipal deserves its own label. 🏷️

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Comment thread src/native/minipal/time.c
@am11

am11 commented Oct 19, 2024

Copy link
Copy Markdown
Member

It must be due to inline otherwise none of the helpers required separate prototype https://github.com/dotnet/runtime/blob/6c7ece9479c7cbb0ca6e372adf0a0154a5f0c1a0/src/native/minipal/utf8.c. We can simply drop the inline and let compiler decide (inline is just a hint and compiler can choose to ignore it if present and vice versa).

@jkoritzinsky

Copy link
Copy Markdown
Member Author

Honestly I just want to get the simple change in to fix the official build. We can do more cleanup in the future.

@jkoritzinsky

Copy link
Copy Markdown
Member Author

/ba-g job is green on AzDO

@am11

am11 commented Oct 19, 2024

Copy link
Copy Markdown
Member

I didn't noticed official build mention. Good call!

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclr only for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants