Avoid IndexOutOfRangeException in ZipArchive

[peter15914]

Fixes #109167

This pull request fixes unexpected IndexOutOfRangeException in ZipArchive.
Additional check added that array index is not out of range.
It is done in a similar way to the code in HuffmanTree.c:230:

if (value > 0)
{
    // prevent an IndexOutOfRangeException from array[index]
    throw new InvalidDataException(SR.InvalidHuffmanData);
}

Found by Linux Verification Center (linuxtesting.org).

[peter15914]

Hello, @ericstj , @dotnet/area-system-io-compression !
Can you review this PR?

[akoeplinger]

@peter15914 FYI you'll need to wait until #109477 is merged to be able to consume the runtime-assets changes. Once that PR is in you can merge main into your branch and you should be able to access the new file.

[peter15914]

@dotnet-policy-service agree

[peter15914]

Hello @stephentoub !
I added unit test for this scenario.
Method ZipArchive_InvalidHuffmanData is made similar to existing functions in zip_InvalidParametersAndStrangeFiles.cs.

[stephentoub]

Hello @stephentoub ! I added unit test for this scenario. Method ZipArchive_InvalidHuffmanData is made similar to existing functions in zip_InvalidParametersAndStrangeFiles.cs.

Thanks!

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

[ericstj]

Left a small suggestion, but I'd like @carlossanlop to review too

[ViktorHofer]

@carlossanlop PTAL

[carlossanlop]

LGTM. The condition makes sense and the test verifies the reported scenario.

[ViktorHofer]

/ba-g a lot of timeouts in different legs for which we already have dnceng issues