Skip to content

JIT: Remove VisitLoopBlocksLexical utility - #110490

Merged
amanasifkhalid merged 1 commit into
dotnet:mainfrom
amanasifkhalid:VisitLoopBlocksLexical-removal
Dec 12, 2024
Merged

JIT: Remove VisitLoopBlocksLexical utility#110490
amanasifkhalid merged 1 commit into
dotnet:mainfrom
amanasifkhalid:VisitLoopBlocksLexical-removal

Conversation

@amanasifkhalid

Copy link
Copy Markdown
Contributor

Follow-up to #110227. In the few places where we still visit loop blocks in lexical order, just visit them in RPO instead.

@amanasifkhalid

Copy link
Copy Markdown
Contributor Author

cc @dotnet/jit-contrib, @jakobbotsch PTAL. Small diffs from churn in the lexical order of cloned loop blocks. Thanks!

@jakobbotsch jakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@amanasifkhalid
amanasifkhalid merged commit 4a30be3 into dotnet:main Dec 12, 2024
@amanasifkhalid
amanasifkhalid deleted the VisitLoopBlocksLexical-removal branch December 12, 2024 15:23
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
Follow-up to dotnet#110227. In the few places where we still visit loop blocks in lexical order, just visit them in RPO instead.
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants