Skip to content

Delete FEATURE_INTERPRETER - #111137

Merged
jkotas merged 3 commits into
dotnet:mainfrom
jkotas:FEATURE_INTERPRETER
Jan 7, 2025
Merged

Delete FEATURE_INTERPRETER#111137
jkotas merged 3 commits into
dotnet:mainfrom
jkotas:FEATURE_INTERPRETER

Conversation

@jkotas

@jkotas jkotas commented Jan 6, 2025

Copy link
Copy Markdown
Member

FEATURE_INTERPRETER is a poorly architected implementation of an interpreter. Proper interpreter implementation should start with a clean slate.

FEATURE_INTERPRETER is a poorly architected implementation of an interpreter. Proper interpreter implementation should start with a clean slate.
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Comment thread src/coreclr/vm/tieredcompilation.cpp Outdated

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@BruceForstall

Copy link
Copy Markdown
Contributor

Is this because a new interpreter implementation is imminent?

@BruceForstall

BruceForstall commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

There's also:

https://github.com/dotnet/runtime/blob/main/eng/pipelines/coreclr/clrinterpreter.yml

to delete. I couldn't find the actual pipeline in AzDO; it hasn't run for a while so maybe it got garbage collected.

Also,

https://github.com/dotnet/runtime/blob/main/docs/design/features/code-generation-strategies.md#interpreter

@jkotas

jkotas commented Jan 7, 2025

Copy link
Copy Markdown
Member Author

Is this because a new interpreter implementation is imminent?

Yes.

@rickbrew

rickbrew commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

Is this because a new interpreter implementation is imminent?

Yes.

Could be interesting for mobile development. I heard of an experiment done at a former employer where the startup time of the (enormous) Java/Android app was actually faster in interpreted mode due to reduced I/O (... on some phones, mind you).

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants