Improve error handling of unknown arch - #114046
Merged
Merged
Conversation
This was referenced Mar 30, 2025
janvorli
reviewed
Apr 2, 2025
am11
force-pushed
the
feature/cmake-configs
branch
from
April 2, 2025 15:43
b153ba8 to
0997a61
Compare
This was referenced Apr 2, 2025
janvorli
approved these changes
Apr 3, 2025
akoeplinger
approved these changes
Apr 3, 2025
Member
|
/ba-g failures are unrelated to this cmake change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these places where this message is displayed are supporting different set of platforms these days than what the message reports. It's better to keep a general message inline and let the line number reveal the context where it failed.
It is only useful during the port work.