Skip to content

CultureName "c" and "C" get mapped to Invariant Culture - #114328

Merged
adamsitnik merged 1 commit into
dotnet:mainfrom
adamsitnik:fuzzerAgain
Apr 9, 2025
Merged

CultureName "c" and "C" get mapped to Invariant Culture#114328
adamsitnik merged 1 commit into
dotnet:mainfrom
adamsitnik:fuzzerAgain

Conversation

@adamsitnik

Copy link
Copy Markdown
Member

Fuzzer has helped me to learn one more thing about culture name mappings:

if (cultureName.Length == 1 && (cultureName[0] == 'C' || cultureName[0] == 'c'))
{
// Always map the "C" locale to Invariant to avoid mapping it to en_US_POSIX on Linux because POSIX
// locale collation doesn't support case insensitive comparisons.
// We do the same mapping on Windows for the sake of consistency.
return Invariant;
}

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

@adamsitnik

Copy link
Copy Markdown
Member Author

@MihuBot fuzz AssemblyNameInfo

@adamsitnik

Copy link
Copy Markdown
Member Author

/ba-g the built has started two days ago and have not finished, it's unrelated

@adamsitnik
adamsitnik merged commit 0e94dca into dotnet:main Apr 9, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants