Create an on-stack instance of FindReferenceTargetsCallback. - #116081
Merged
AaronRobinsonMSFT merged 2 commits intoMay 29, 2025
Conversation
This would remove the transient static value that must be manually managed. It also removes an odd FixedAddressValueType instance.
Member
Author
|
/cc @jkoritzinsky @agocke |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TrackerObjectManager to eliminate a transient static field by creating an on‑stack instance of FindReferenceTargetsCallback.
- Removed the static s_findReferencesTargetCallback field and its associated static GCHandle.
- Replaced static callback usage with an on‑stack ref struct instance to better manage lifetime and thread-safety.
Comments suppressed due to low confidence (1)
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/TrackerObjectManager.NativeAot.cs:204
- [nitpick] The type name 'Instance' is generic and may cause confusion when reading the code. Consider renaming it to something more descriptive, such as 'OnStackCallback', to clearly indicate its purpose.
internal ref struct Instance
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkoritzinsky
approved these changes
May 28, 2025
This was referenced May 29, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would remove the transient static value that must be manually managed. It also removes an
unnecessary
FixedAddressValueTypestatic field.