Try fixing native AOT outerloop runs - #116961
Merged
Merged
Conversation
Member
Author
|
/azp run runtime-nativeaot-outerloop |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues in native AOT outerloop runs by improving type resolution in the AOT compiler. The key change is the update to the type retrieval logic in TypeMapMetadata.cs to use GetObject with NotFoundBehavior.ReturnNull and an added null-check to safely skip unresolved types.
Comments suppressed due to low confidence (1)
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypeMapMetadata.cs:168
- The update to use NotFoundBehavior.ReturnNull is appropriate; ensure that the null-check and early continue fully address any downstream issues when the attribute type is unresolved.
TypeDesc type = (TypeDesc)currentAssembly.GetObject(attributeType, NotFoundBehavior.ReturnNull);
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 24, 2025
jkotas
approved these changes
Jun 24, 2025
Member
Author
|
/ba-g timeout in networking test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.