Cleanup named mutex tests - #117128
Merged
Merged
Conversation
Deduplicate issues for missing cross-process named mutex support on NativeAOT and Mono Closes dotnet#70127
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes the logic for skipping named-mutex tests on platforms without cross-process support and cleans up individual ActiveIssue attributes.
- Introduces
IsCrossProcessNamedMutexSupportedto determine when cross-process named mutexes are supported. - Replaces scattered
[ActiveIssue]attributes with[ConditionalFact]and[ConditionalTheory]driven by the new predicate. - Updates
GetValidNamesto account for platforms lacking cross-process named mutex support.
This was referenced Jun 29, 2025
mangod9
reviewed
Jun 30, 2025
jkotas
commented
Jun 30, 2025
MichalStrehovsky
approved these changes
Jun 30, 2025
jkotas
commented
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicate issues for missing cross-process named mutex support on NativeAOT and Mono
Closes #70127