Fix the issue that the test exits with cannot find Microsoft.Win32.Primitives.dll #117699
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR extends the custom assembly resolver to also load framework assemblies whose names start with "Microsoft." from the framework path.
- Updated the
ifcondition to include assemblies beginning with"Microsoft." - Added a clarifying comment about loading framework assemblies
Comments suppressed due to low confidence (1)
src/tests/GC/Stress/Framework/ReliabilityFramework.cs:54
- Add a unit or integration test to verify that assemblies starting with "Microsoft." are correctly resolved by
CustomAssemblyResolver.
if (assemblyName.Name.StartsWith("System.") || assemblyName.Name.StartsWith("Microsoft."))
| @@ -51,8 +51,9 @@ public CustomAssemblyResolver() | |||
| protected override Assembly Load(AssemblyName assemblyName) | |||
| { | |||
| string strPath; | |||
| if (assemblyName.Name.StartsWith("System.")) | |||
| if (assemblyName.Name.StartsWith("System.") || assemblyName.Name.StartsWith("Microsoft.")) | |||
There was a problem hiding this comment.
[nitpick] Specify StringComparison when using StartsWith for consistent, culture-insensitive matching (e.g., StartsWith("System.", StringComparison.Ordinal)).
Suggested change
| if (assemblyName.Name.StartsWith("System.") || assemblyName.Name.StartsWith("Microsoft.")) | |
| if (assemblyName.Name.StartsWith("System.", StringComparison.Ordinal) || assemblyName.Name.StartsWith("Microsoft.", StringComparison.Ordinal)) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load the name of dll that starts with "Microsoft." from the framework path.