Skip to content

SVE2 API for MaxNumberPairwise, MaxPairwise, MinNumberPairwise and MinPairwise #117711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

jacob-crawley
Copy link
Contributor

@dotnet/arm64-contrib @amanasifkhalid @a74nh

Contributing towards #115479

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 16, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll do another pass once the merge conflicts are resolved

@amanasifkhalid amanasifkhalid enabled auto-merge (squash) July 16, 2025 16:42
Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacob-crawley there are some test failures to sort through:

Sve2.MaxPairwise<Byte>(Vector<Byte>, Vector<Byte>): ConditionalSelectScenario_TrueValue failed:
    mask: (1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 1, 1, 0)
    left: (166, 253, 151, 253, 158, 255, 68, 231, 161, 217, 94, 114, 194, 112, 48, 190)
   right: (85, 244, 208, 130, 155, 80, 85, 246, 138, 36, 77, 89, 66, 48, 199, 13)
 falseOp: (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)
  result: (253, 244, 0, 208, 255, 155, 0, 246, 217, 138, 94, 0, 0, 66, 48, 0)

auto-merge was automatically disabled July 17, 2025 15:37

Head branch was pushed to by a user without write access

Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@amanasifkhalid
Copy link
Member

/ba-g build timeouts

@amanasifkhalid amanasifkhalid merged commit 2c8a0da into dotnet:main Jul 18, 2025
150 of 159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants