-
Notifications
You must be signed in to change notification settings - Fork 5.1k
SVE2 API for MaxNumberPairwise, MaxPairwise, MinNumberPairwise and MinPairwise #117711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll do another pass once the merge conflicts are resolved
7efb3a2
to
3d7e9ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacob-crawley there are some test failures to sort through:
Sve2.MaxPairwise<Byte>(Vector<Byte>, Vector<Byte>): ConditionalSelectScenario_TrueValue failed:
mask: (1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 1, 1, 0)
left: (166, 253, 151, 253, 158, 255, 68, 231, 161, 217, 94, 114, 194, 112, 48, 190)
right: (85, 244, 208, 130, 155, 80, 85, 246, 138, 36, 77, 89, 66, 48, 199, 13)
falseOp: (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)
result: (253, 244, 0, 208, 255, 155, 0, 246, 217, 138, 94, 0, 0, 66, 48, 0)
Head branch was pushed to by a user without write access
3d7e9ac
to
308e8a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
/ba-g build timeouts |
@dotnet/arm64-contrib @amanasifkhalid @a74nh
Contributing towards #115479