-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[browser] Migrate WebAssemblyHotReloadCapabilities from Blazor to WasmSDK #117747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @tmat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates WebAssembly Hot Reload capabilities configuration from Blazor-specific settings to the broader WasmSDK, making Hot Reload functionality available for all WebAssembly browser scenarios. This change supports the introduction of a new HotReload package in the SDK that will be automatically referenced by WasmSDK.
Key changes:
- Moves .NET version detection logic to an earlier PropertyGroup for reuse
- Adds WebAssemblyHotReloadCapabilities property with framework-specific capability sets
- Removes duplicate version detection code from the _ResolveWasmConfiguration target
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Show resolved
Hide resolved
Tagging subscribers to 'arch-wasm': @lewing |
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Show resolved
Hide resolved
/ba-g Timeouts are covered in other architecture legs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
In dotnet/sdk#49800 we are introducing a HotReload package that will be automatically referenced by WasmSDK and usable for all WebAssembly in browser scenarios. We need to set HotReload capabilities in a common place.
In .NET 8+ the runtime capabilities are the same.
Manually tested that HotReload is able to pick the value after removing it from Blazor
Contributes to dotnet/aspnetcore#61272