Expose the extension operators for Tensor, TensorSpan, and ROTensorSpan #117997
Conversation
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
| try | ||
| { | ||
| TrimDataFlowAnalysis trimDataFlowAnalysis = new(context, dataFlowAnalyzerContext, operationBlock); | ||
| trimDataFlowAnalysis.InterproceduralAnalyze(); | ||
| trimDataFlowAnalysis.ReportDiagnostics(context.ReportDiagnostic); | ||
| foreach (var operationBlock in context.OperationBlocks) | ||
| { | ||
| TrimDataFlowAnalysis trimDataFlowAnalysis = new(context, dataFlowAnalyzerContext, operationBlock); | ||
| trimDataFlowAnalysis.InterproceduralAnalyze(); | ||
| trimDataFlowAnalysis.ReportDiagnostics(context.ReportDiagnostic); | ||
| } | ||
| } | ||
| catch (InvalidCastException) | ||
| { | ||
| // Newer language features may produce NonErrorNamedTypeSymbol | ||
| // which will fail to cast to a given target type. Catch and | ||
| // ignore the failure in this scenario since it otherwise blocks | ||
| // the analyzer | ||
| } |
There was a problem hiding this comment.
@dotnet/illink this was being hit for the new user-defined compound assignment operators.
I wasn't able to get a stack trace or figure out how to get this to debug, so I couldn't determine what wasn't handling the scenario correctly. But something in the InterproceduralAnalyze() call gets a NonErrorNamedTypeSymbol and then tries to cast it to an IMethodSymbol, which fails and brings down the whole analyzer.
There was a problem hiding this comment.
I think this might be from one of the (IMethodSymbol)parameter.ContainingSymbol casts; since extension(T name) { } is now possible and not a method.
… that are not on methods so the analyzer doesn't throw
This resolves #112781