Make the InvalidSysctl exception more descriptive #119218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
Author
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
reviewed
Aug 30, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 30, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 30, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 30, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
added
os-freebsd
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
jeffhandley
approved these changes
Sep 2, 2025
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
LGTM, but I'll wait for @jkotas to re-review before we merge.
jkotas
reviewed
Sep 2, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 2, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 2, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 2, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
The parameter being acted on by sysctl() call is determined by an arbitrarily sized array of integers called MIB. The current version of the code only prints the first element of the MIB, which isn't descriptive at all. Change it to print all elements of the MIB tuple. While there, make type signatures of low-level functions match their C versions. The problem was raised by a FreeBSD user: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289022
jkotas
reviewed
Sep 2, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 2, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 2, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 3, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 3, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 3, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 3, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 3, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 3, 2025
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
Outdated
Show resolved
Hide resolved
Member
|
/ba-g known issues + timeouts |
Member
|
Thank you! |
Contributor
Author
|
Thank you too @jkotas for picking this up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter being acted on by sysctl() call is determined by an arbitrarily sized array of integers called MIB. The current version of the code only prints the first element of the MIB, which isn't descriptive at all. This change tries to print 4 elements, which should be enough for most of sysctls in the wild.
While there, make type signatures of low-level functions match their C versions.
The problem was raised by a FreeBSD user:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289022