-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[wasm coreclr] enable corerun on nodeJS #119250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cbb5324 to
5b56511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the corerun host application to work on Node.js for WebAssembly (WASM) CoreCLR builds. The changes implement Node.js-specific functionality and remove browser-specific assumptions to allow running .NET assemblies directly in Node.js environments.
Key changes:
- Replace inline assembly debugger break with Emscripten's debugger function
- Add static linking support for WASM builds with Node.js file system access
- Implement environment variable passing from Node.js to Emscripten runtime
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/coreclr/pal/src/arch/wasm/stubs.cpp |
Replace inline assembly with emscripten_debugger() for proper Node.js debugging |
src/coreclr/hosts/corerun/corerun.js |
Add JavaScript pre-run script to copy Node.js environment variables to Emscripten |
src/coreclr/hosts/corerun/corerun.hpp |
Add WASM-specific conditional compilation to disable dynamic library loading |
src/coreclr/hosts/corerun/corerun.cpp |
Implement static symbol resolution for WASM builds instead of dynamic loading |
src/coreclr/hosts/corerun/CMakeLists.txt |
Configure WASM build with static linking, Node.js file system, and required libraries |
src/coreclr/hosts/CMakeLists.txt |
Enable corerun build for WASM targets alongside existing corewasmrun |
docs/workflow/building/coreclr/wasm.md |
Update documentation to reflect corerun usage instead of corewasmrun for Node.js |
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you. Please address the CMake feedback and then let's get this merged!
Uh oh!
There was an error while loading. Please reload this page.