[maccatalyst] Check for -Wno-overriding-option for compatibility with clang in Xcode 16.3+ #119260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clang in Xcode 16.3+ llvm/llvm-project@1c66d08 renamed the option `-Wno-overriding-t-option` to `-Wno-overriding-option`. This caused some configure time checks in CMake to fail because of hitting an unknown compiler option.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a compatibility issue with newer versions of clang in Xcode 16.3+ where the compiler flag -Wno-overriding-t-option was renamed to -Wno-overriding-option. The changes implement dynamic detection of which flag the compiler supports to maintain compatibility across different clang versions.
Key changes:
- Remove hardcoded
-Wno-overriding-t-optionflag from mono.proj - Add compiler capability detection in CMake files to check for both flag variants
- Implement fallback logic to use the appropriate flag based on compiler support
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mono/mono.proj | Removes hardcoded -Wno-overriding-t-option flag from MacCatalyst build configuration |
| src/mono/CMakeLists.txt | Adds compiler flag detection logic for MacCatalyst builds with fallback support |
| eng/native/configurecompiler.cmake | Updates compiler configuration to dynamically detect and use the correct overriding option flag |
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17402363409 |
4 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ViktorHofer
approved these changes
Sep 2, 2025
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Sep 3, 2025
… clang in Xcode 16.3+ (dotnet#119260) llvm/llvm-project@1c66d08 renamed the option `-Wno-overriding-t-option` to `-Wno-overriding-option`. This caused some configure time checks in CMake to fail because of hitting an unknown compiler option. (cherry picked from commit 4b8a478)
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Sep 3, 2025
… clang in Xcode 16.3+ (dotnet#119260) llvm/llvm-project@1c66d08 renamed the option `-Wno-overriding-t-option` to `-Wno-overriding-option`. This caused some configure time checks in CMake to fail because of hitting an unknown compiler option. (cherry picked from commit 4b8a478) (cherry picked from commit f08548f)
akoeplinger
added a commit
that referenced
this pull request
Sep 4, 2025
… clang in Xcode 16.3+ (#119260) (#119301) llvm/llvm-project@1c66d08 renamed the option `-Wno-overriding-t-option` to `-Wno-overriding-option`. This caused some configure time checks in CMake to fail because of hitting an unknown compiler option. (cherry picked from commit 4b8a478)
akoeplinger
added a commit
that referenced
this pull request
Sep 4, 2025
… clang in Xcode 16.3+ (#119260) (#119303) llvm/llvm-project@1c66d08 renamed the option `-Wno-overriding-t-option` to `-Wno-overriding-option`. This caused some configure time checks in CMake to fail because of hitting an unknown compiler option. (cherry picked from commit 4b8a478) (cherry picked from commit f08548f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project@1c66d08 renamed the option
-Wno-overriding-t-optionto-Wno-overriding-option. This caused some configure time checks in CMake to fail because of hitting an unknown compiler option.This fixes the MacCatalyst build with Xcode 16.3 which is currently being rolled out on the macOS images by Azure Pipelines.