Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 25, 2025

Backport of #119399 to release/10.0

/cc @LoopedBard3 @matouskozak

Customer Impact

  • Customer reported
  • Found internally

No customer impact, impacts the performance pipelines. (https://dev.azure.com/dnceng/internal/_build/results?buildId=2801881&view=results)

Regression

  • Yes
  • No

Caused by the general updates made to the performance flow here: dotnet/performance#4933

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

Low due to being an infra/yml fix that impacts only the performance pipelines, which have failures due to not having this update.

@LoopedBard3 LoopedBard3 added area-Infrastructure perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Sep 25, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@LoopedBard3
Copy link
Member

FYI @matouskozak @caaavik-msft

@AaronRobinsonMSFT Is merging into release/10.0 currently the correct approach for backporting to net10.0? If so, can I get it looked at and merged? Let me know if there is a different process I should follow. Thanks.

@AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT Is merging into release/10.0 currently the correct approach for backporting to net10.0? If so, can I get it looked at and merged? Let me know if there is a different process I should follow. Thanks.

Yes, it is the correct branch to target. Let me ping you offline and go over the process.

@AaronRobinsonMSFT AaronRobinsonMSFT added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 25, 2025
@JulieLeeMSFT
Copy link
Member

Please get code review.

@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Sep 26, 2025
Copy link
Contributor

@caaavik-msft caaavik-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

My only comment is that by changing the artifact names it prevents us from being able to run performance tests against runtime commit versions that used the old artifact name. As a separate piece of work we should figure out how to remove this coupling so that the artifacts and their names can change independently of the test suite.

@JulieLeeMSFT JulieLeeMSFT merged commit ec27556 into release/10.0 Sep 26, 2025
28 of 32 checks passed
@JulieLeeMSFT JulieLeeMSFT deleted the backport/pr-119399-to-release/10.0 branch September 26, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines Servicing-approved Approved for servicing release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants