Skip to content

[release/9.0-staging] Don't assume all S_IFREG files are seekable #120838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/9.0-staging
Choose a base branch
from
Open

[release/9.0-staging] Don't assume all S_IFREG files are seekable #120838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71bbec0
Don't assume all S_IFREG files are seekable
rzikm Oct 15, 2025
f47730b
Attempt 2
rzikm Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,10 @@ private bool Init(string path, FileMode mode, FileAccess access, FileShare share
// and for regular files (most common case)
// avoid one extra sys call for determining whether file can be seeked
_canSeek = NullableBool.True;
Debug.Assert(Interop.Sys.LSeek(this, 0, Interop.Sys.SeekWhence.SEEK_CUR) >= 0);

// we exclude 0-length files from the assert because those may may be pseudofiles
// (e.g. /proc/net/route) and these are not seekable on all systems
Debug.Assert(status.Size == 0 || Interop.Sys.LSeek(this, 0, Interop.Sys.SeekWhence.SEEK_CUR) >= 0);
}

fileLength = status.Size;
Expand Down
Loading