Skip to content

fix SupportsWasmIntrinsics - #125046

Merged
pavelsavara merged 2 commits into
dotnet:mainfrom
pavelsavara:browser_SupportsWasmIntrinsics
Mar 3, 2026
Merged

fix SupportsWasmIntrinsics#125046
pavelsavara merged 2 commits into
dotnet:mainfrom
pavelsavara:browser_SupportsWasmIntrinsics

Conversation

@pavelsavara

Copy link
Copy Markdown
Member

No description provided.

@pavelsavara pavelsavara added this to the 11.0.0 milestone Mar 2, 2026
@pavelsavara
pavelsavara requested a review from radekdoulik March 2, 2026 13:03
@pavelsavara pavelsavara self-assigned this Mar 2, 2026
Copilot AI review requested due to automatic review settings March 2, 2026 13:04
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm area-CodeGen-Interpreter-coreclr labels Mar 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CoreLib’s build-time feature detection so WebAssembly intrinsics are only enabled for the Mono runtime flavor, avoiding inclusion of intrinsic implementations in non-Mono WASM builds.

Changes:

  • Gate SupportsWasmIntrinsics on both $(Platform) == wasm and $(RuntimeFlavor) == Mono.
  • Add an explicit default SupportsWasmIntrinsics=false when not otherwise set.

Comment thread src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated
@pavelsavara
pavelsavara enabled auto-merge (squash) March 2, 2026 19:27

@radekdoulik radekdoulik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@pavelsavara
pavelsavara merged commit 3f4b0c5 into dotnet:main Mar 3, 2026
146 of 148 checks passed
@pavelsavara
pavelsavara deleted the browser_SupportsWasmIntrinsics branch March 3, 2026 00:29
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-CodeGen-Interpreter-coreclr os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants