Skip to content

[browser] Fix WebAssembly publish output path message #132829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maraf merged 2 commits into from
Sep 7, 2026
+42 −1
Merged

[browser] Fix WebAssembly publish output path message #132829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
725a0fb
Fix WebAssembly publish output path message (#99292)
maraf Aug 27, 2026
1eae215
Clarify WebAssembly target section comment
maraf Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...et/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,13 +961,24 @@ Copyright (c) .NET Foundation. All rights reserved.
</PropertyGroup>
</Target>

<!-- Publish starts here -->
<!-- Publish targets and output directory messages start here -->

<!-- Make sure that ResolveAssemblyReferences runs early enough to ensure satellite assemblies are populated in the ResolvedFilesToPublish -->
<Target Name="_WasmPrepareForPublish"
DependsOnTargets="PrepareResourceNames;ComputeIntermediateSatelliteAssemblies;ResolveAssemblyReferences"
BeforeTargets="PrepareForPublish" />

<Target Name="_PrintWasmBrowserPublishOutputDirectory" AfterTargets="Publish" Condition="'$(WasmBuildingForNestedPublish)' != 'true'">
<Message Importance="High" Text="$(MSBuildProjectName) (wwwroot) -&gt; $([MSBuild]::NormalizeDirectory('$(PublishDir)', 'wwwroot'))" />
</Target>

<Target Name="_PrintWasmBrowserBuildOutputDirectory" AfterTargets="CopyFilesToOutputDirectory" Condition="'$(WasmBuildingForNestedPublish)' != 'true'">
Comment thread
maraf marked this conversation as resolved.
<Message
Importance="High"
Text="$(MSBuildProjectName) (wwwroot) -&gt; $([MSBuild]::NormalizeDirectory('$(TargetDir)', 'wwwroot'))"
Condition="'$(CopyBuildOutputToOutputDirectory)' == 'true' and '$(SkipCopyBuildProduct)' != 'true'" />
</Target>

<!-- Wasm's Nested publish is run just to build the native bits. We don't need to run blazor targets for that -->
<Target Name="ProcessPublishFilesForWasm" DependsOnTargets="_ResolveWasmConfiguration;LoadStaticWebAssetsBuildManifest;_GatherWasmFilesToPublish" AfterTargets="ILLink" Condition="'$(WasmBuildingForNestedPublish)' != 'true'">
<!-- The list of static web assets already contains all the assets from the build. We want to correct certain assets that might
Expand Down
30 changes: 30 additions & 0 deletions src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,36 @@ public void BrowserBuildThenPublish(Configuration config)
PublishProject(info, config, new PublishOptions(UseCache: false));
}

[Theory, TestCategory("no-fingerprinting"), TestCategory("workload")]
[InlineData(Configuration.Debug)]
[InlineData(Configuration.Release)]
public void BrowserBuildAndPublishOutputDirectories(Configuration config)
{
ProjectInfo info = CreateWasmTemplateProject(Template.WasmBrowser, config, aot: false, "output_directory");
(string projectDir, string buildOutput) = BuildProject(info, config);

string buildOutputDirectory = Path.Combine(
projectDir,
"bin",
config.ToString(),
DefaultTargetFramework,
"wwwroot") + Path.DirectorySeparatorChar;
string buildMessage = $"{info.ProjectName} (wwwroot) -> {buildOutputDirectory}";
Assert.Equal(1, buildOutput.Split(buildMessage).Length - 1);

(_, string publishOutput) = PublishProject(info, config, new PublishOptions(UseCache: false));

string publishOutputDirectory = Path.Combine(
projectDir,
"bin",
config.ToString(),
DefaultTargetFramework,
"publish",
"wwwroot") + Path.DirectorySeparatorChar;
string publishMessage = $"{info.ProjectName} (wwwroot) -> {publishOutputDirectory}";
Assert.Equal(1, publishOutput.Split(publishMessage).Length - 1);
}

public static TheoryData<bool, string> TestDataForAppBundleDir()
{
var data = new TheoryData<bool, string>();
Expand Down