Make sure separated_poh_p and use_large_pages_p works together - #50665
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue Details
|
|
Tagging subscribers to this area: @dotnet/gc Issue Details
|
Maoni0
reviewed
Apr 3, 2021
Maoni0
reviewed
Apr 3, 2021
Maoni0
reviewed
Apr 3, 2021
cshung
force-pushed
the
public/fix-separate-poh
branch
from
April 5, 2021 23:58
f6eaec2 to
b643074
Compare
This was referenced Apr 9, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes 3 issues in the area:
If we decided to give some memory to POH even when it is set to 0, we should adjust the corresponding
heap_hard_limitandheap_hard_limit_ohto avoid failing thevirtual_commitcall. Thevirtual_commitcall consumes theheap_hard_limitregardless of whether or not the memory is actually committed.In the large page case, if we decided to allocate the POH part of the memory using normal pages, then we need to commit them as well because the rest of the system assumes all the memory of large page cases is committed upfront.
virtual_freecould be called byreserve_initial_memoryif the memory operations fail, therefore it could be called in theheap_hard_limitcase as well, removing the erroneous assert in that case.