Allow build with VS2022 installed - #52487
Merged
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
danmoseley
approved these changes
May 10, 2021
danmoseley
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable, if it works for you.
Contributor
|
@dotnet/dnceng |
Contributor
|
The other issue is #52527. |
Contributor
|
thanks @BrennanConroy |
|
@danmoseley Regarding the failure you linked above #52487 (comment) - it's probably intermittent AzDO issue. @MattGal elaborated a bit more about it here: #52420 (comment). |
Member
|
should we also update runtime/eng/native/gen-buildsys.cmd Lines 31 to 32 in 403ae35 |
Contributor
|
At present CMake has no special support for Visual Studio 2022, so we should probably use "Visual Studio 16 2019" unconditionally for now. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.